Skip to content

feat: add cmd substitution for config variables#8917

Open
nikaro wants to merge 1 commit intoanomalyco:devfrom
nikaro:feat/exec-substitution
Open

feat: add cmd substitution for config variables#8917
nikaro wants to merge 1 commit intoanomalyco:devfrom
nikaro:feat/exec-substitution

Conversation

@nikaro
Copy link

@nikaro nikaro commented Jan 16, 2026 •
edited
Loading

What does this PR do?

Add an "cmd substitution" that allow to use password manager to pass credentials in configuration.

Fixes #231

How did you verify your code works?

  • Added test case
  • Ran bun dev with some {cmd:op read ...} in my configuration file

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found:

PR #8198: feat: add apiKeyCommand for dynamic API key retrieval
#8198

Why it might be related: Both PRs appear to address the same problem—dynamically retrieving credentials/API keys at runtime rather than storing them statically in configuration. PR #8198 uses apiKeyCommand for dynamic API key retrieval, while PR #8917 uses exec substitution for the same purpose. These are different implementation approaches to solving the same issue (#7487).

nikaro
nikaro commented Jan 16, 2026
View reviewed changes
packages/opencode/src/config/config.ts
}
const command = match.replace(/^\{exec:/, "").replace(/\}$/, "")
try {
const result = await Bun.$`sh -c ${command}`.text()
Copy link
Author

@nikaro nikaro Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this instead of the supposedly more secure Bun.Spawn because it is much simpler as we don't have to parse/split the user command and handle all the quirks (do not split quoted arguments, what to do about pipes and redirections, etc.).

@nikaro nikaro mentioned this pull request Jan 16, 2026
Open
@betaboon
Copy link

betaboon commented Jan 16, 2026

i have no say in this, but it would be fantastic if this could become {cmd:foo bar} instead, because it aligns well with some other tools that i am using.

@nikaro
Copy link
Author

nikaro commented Jan 16, 2026

i have no say in this, but it would be fantastic if this could become {cmd:foo bar} instead, because it aligns well with some other tools that i am using.

I don't mind, I actually had some hesitation between exec and cmd. I will change.

@nikaro nikaro force-pushed the feat/exec-substitution branch from 3702bdf to 8bafe55 Compare January 16, 2026 16:36
@nikaro nikaro changed the title feat: add exec substitution for config variables feat: add cmd substitution for config variables Jan 16, 2026
@nikaro nikaro force-pushed the feat/exec-substitution branch 3 times, most recently from 83fd4ee to a096b5c Compare January 20, 2026 09:09
@nikaro nikaro mentioned this pull request Jan 20, 2026
Open
@nikaro nikaro force-pushed the feat/exec-substitution branch from a096b5c to 34daa43 Compare January 28, 2026 13:21
@thdxr thdxr force-pushed the dev branch 3 times, most recently from f1ae801 to 08fa7f7 Compare January 30, 2026 14:37
@nikaro nikaro force-pushed the feat/exec-substitution branch from 34daa43 to 6231b23 Compare January 30, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add ability to load secrets from external command or environment variables in the config file

2 participants

@nikaro @betaboon